Fix @testing-library/jest-dom types properly

upleveled · May 5, 2023 · 0c6a178 · 0c6a178
1 parent f98af47
commit 0c6a178
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -37,6 +37,7 @@
     "@types/testing-library__jest-dom": "5.14.5",
     "eslint": "8.39.0",
     "eslint-config-upleveled": "4.2.1",
+    "expect": "^29.5.0",
     "stylelint": "^15.5.0",
     "stylelint-config-upleveled": "^1.0.2",
     "typescript": "5.0.4"

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/App.test.js b/src/App.test.js
@@ -5,6 +5,5 @@ import App from './App';
 test('renders learn react link', () => {
   render(<App />);
   const linkElement = screen.getByText(/learn react/i);
-  // @ts-ignore -- Getting proper types for @testing-library/jest-dom is not simple https://github.com/testing-library/jest-dom/issues/123#issuecomment-1536490617
   expect(linkElement).toBeInTheDocument();
 });
diff --git a/src/react-app-env.d.ts b/src/react-app-env.d.ts
@@ -1 +1,9 @@
 /// <reference types="react-scripts" />
+import { expect } from '@jest/globals';
+import { TestingLibraryMatchers } from '@testing-library/jest-dom/matchers';
+
+declare module 'expect' {
+  interface AsymmetricMatchers {}
+  interface Matchers<R = void>
+    extends TestingLibraryMatchers<typeof expect.stringContaining, R> {}
+}
diff --git a/tsconfig.json b/tsconfig.json
@@ -4,7 +4,6 @@
   "compilerOptions": {
     "checkJs": true
   },
-  "types": ["node", "jest", "@testing-library/jest-dom"],
   "include": [
     "**/.eslintrc.cjs",
     "**/*.ts",