Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PVC selection to enable update of VolumeReclaimPolicy of PV #161

Merged
merged 3 commits into from
Mar 28, 2018

Conversation

splisson-altair
Copy link
Contributor

The function was using the hardcoded example-elasticsearch cluster name

@stevesloka stevesloka merged commit f0b9dd8 into upmc-enterprises:master Mar 28, 2018
@gianrubio
Copy link
Contributor

This PR broke the master branch, elasticsearch nodes never start up because Probes are failing. If you didn't setup the use-ssl flag golang will assume the var value as false

                 node.alpha.kubernetes.io/unreachable:NoExecute for 300s
Events:
  Type     Reason      Age                  From                                                Message
  ----     ------      ----                 ----                                                -------
  Warning  Unhealthy   5m (x2941 over 17h)  kubelet, ip-10-120-0-10.eu-west-1.compute.internal  Liveness probe failed: Get http://100.96.3.11:9200/_nodes/_local: EOF
  Warning  FailedSync  2s (x2476 over 17h)  kubelet, ip-10-120-0-10.eu-west-1.compute.internal  Error syncing pod

@gianrubio
Copy link
Contributor

@splisson-altair you also missed to disable ssl in cerebro deployment

@splisson-altair
Copy link
Contributor Author

the use-ssl part should not have ended up here, my bad.
I'll have a look, thanks

@splisson-altair
Copy link
Contributor Author

splisson-altair commented Apr 6, 2018

@gianrubio I see your other pull request , I ll use it as a reference to fix this , ok ?

@splisson-altair
Copy link
Contributor Author

I have not figured out how to make use-ssl default to yes since we're using struct without constructor for the cluster spec.

splisson-altair added a commit to splisson-altair/elasticsearch-operator that referenced this pull request Apr 26, 2018
stevesloka referenced this pull request Apr 27, 2018
Fixes for usage of use-ssl option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants