Skip to content
This repository has been archived by the owner on May 10, 2021. It is now read-only.

Updating package.json to remedy security vulnerability warnings. #153

Closed
wants to merge 6 commits into from

Conversation

localredhead
Copy link
Contributor

     - Karma is still presenting issues https://github.com/karma-runner/karma/issues/2994 in version 2.0.4 and has known
       vulnerabilities in log4js which is a sub-dependency of karma

@ghost ghost assigned localredhead Jul 9, 2018
@ghost ghost added the review label Jul 9, 2018
         - Karma is still presenting issues in version 2.0.4 and has known
           vulnerabilities in log4js which is a sub-dependency of karma
@localredhead localredhead force-pushed the feature/update-dependencies-for-july branch from 0b92484 to eb979ae Compare July 9, 2018 13:21
@c-castillo
Copy link
Contributor

Karma is getting some timeouts 🤔
Probably is a better idea to don't major upgrade karma (leave it to 2.x.x) if that's possible

@pelle
Copy link
Contributor

pelle commented Jul 9, 2018

@c-castillo @localredhead I want to replace karma with jest at some point. It's much simpler to setup and run

Copy link
Contributor

@pelle pelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@localredhead also update yarn.lock

Did you try doing a test build npm build to see if it builds fine?

@pelle pelle added this to the uPort iis Sprint 1 milestone Jul 15, 2018
@pelle
Copy link
Contributor

pelle commented Jul 18, 2018

@localredhead Lets see if changing the karma verion to a minor version release instead. Eg. 1.7.1

Make sure to run yarn as well to update yarn.lock

I would like to get this in today

@localredhead
Copy link
Contributor Author

I've checked all versions of Karma 1.7.1, 2.0.0, 2.0.2, 2.0.3, 2.0.4. All versions have issues, 1.7.1 being the worst (but has the same problems as 1.5.0).

Log4j just released version 3.0.0 which should fix this issue. We need Karma to pull it in upstream and release 2.0.5 with the package updates.

It looks like another day or two and it will be ready

@localredhead
Copy link
Contributor Author

karma-runner/karma#3016

@localredhead
Copy link
Contributor Author

I updated Karma to the commit against their master that fixes the security issues. npm audit produces:

                       === npm audit security report ===                        
                                                                                
┌──────────────────────────────────────────────────────────────────────────────┐
│                                Manual Review                                 │
│            Some vulnerabilities require your attention to resolve            │
│                                                                              │
│         Visit https://go.npm.me/audit-guide for additional guidance          │
└──────────────────────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Low           │ Prototype Pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ lodash                                                       │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in>=4.17.5                                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ publish-release [dev]                                        │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ publish-release > inquirer > lodash                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://nodesecurity.io/advisories/577                       │
└───────────────┴──────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Low           │ Prototype Pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ lodash                                                       │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in>=4.17.5                                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ publish-release [dev]                                        │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ publish-release > lodash                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://nodesecurity.io/advisories/577                       │
└───────────────┴──────────────────────────────────────────────────────────────┘

[!] 2 vulnerabilities found - Packages audited: 11670 (11443 dev, 500 optional)
    Severity: 2 Low

@pelle
Copy link
Contributor

pelle commented Jul 30, 2018

@c-castillo @localredhead this is still failing. Any news on it?

@c-castillo
Copy link
Contributor

@pelle Karma update doesn't prevent the karma CI to fail. I will continue debugging this to see if we can get to a solution

@localredhead
Copy link
Contributor Author

Closing this. We've solved it by removing Karma in favor of Jest.

@ghost ghost removed the review label Aug 6, 2018
@rmw2 rmw2 deleted the feature/update-dependencies-for-july branch October 12, 2018 18:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants