Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Fix Migrations #136

Merged
merged 2 commits into from
May 7, 2019
Merged

Fix Migrations #136

merged 2 commits into from
May 7, 2019

Conversation

pelle
Copy link
Contributor

@pelle pelle commented May 7, 2019

There was a regression in keychain, that I think was caused by merging the native signer.

@pelle pelle requested a review from simonas-notcat May 7, 2019 03:58
@codecov
Copy link

codecov bot commented May 7, 2019

Codecov Report

Merging #136 into develop will decrease coverage by 0.01%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #136      +/-   ##
==========================================
- Coverage    54.21%   54.2%   -0.02%     
==========================================
  Files          260     260              
  Lines         8745    8743       -2     
  Branches      1789    1790       +1     
==========================================
- Hits          4741    4739       -2     
  Misses        3570    3570              
  Partials       434     434
Impacted Files Coverage Δ
lib/sagas/pututu.js 77.14% <ø> (-0.33%) ⬇️
lib/sagas/migrations/MigrateLegacy.ts 85.71% <ø> (-0.23%) ⬇️
lib/sagas/index.js 0% <ø> (ø) ⬆️
lib/components/Recovery/SeedRecoveryPhrase.js 0% <0%> (ø) ⬆️
lib/sagas/recoverySaga.js 88.37% <100%> (ø) ⬆️
lib/actions/recoveryActions.js 83.33% <100%> (ø) ⬆️
lib/sagas/keychain.js 75.7% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c1a5e7...9088eb2. Read the comment docs.

Copy link
Contributor

@simonas-notcat simonas-notcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@simonas-notcat simonas-notcat merged commit b9bdb9d into develop May 7, 2019
@mirceanis mirceanis deleted the feature/#165030199/fix-migrations branch January 22, 2020 11:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants