Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Migrate all old Identities to ETHR DID #59

Merged
merged 39 commits into from
Feb 28, 2019

Conversation

pelle
Copy link
Contributor

@pelle pelle commented Jan 13, 2019

This creates 4 different scenarios for old identities:

  • if you have an identity without a HD wallet and attestations or mainnet accounts it updates it to use a HD wallet
  • If you have a HD identity and the seed is no longer in your keychain it is likely because you have a new phone. Hook to ask for Recover Seed. (To be implemented in sister PR)
  • If you have an EthrDID or a HD Legacy Identity it doesn't do anything
  • For all other legacy identities it creates a new modern ETHR Identity and copies over old data

@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@bf3aba9). Click here to learn what that means.
The diff coverage is 83.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #59   +/-   ##
==========================================
  Coverage           ?   61.17%           
==========================================
  Files              ?      275           
  Lines              ?     9149           
  Branches           ?     1887           
==========================================
  Hits               ?     5597           
  Misses             ?     3148           
  Partials           ?      404
Impacted Files Coverage Δ
lib/sagas/requests/verificationSignRequest.js 0% <ø> (ø)
lib/sagas/startupSaga.js 0% <ø> (ø)
lib/sagas/metrics.js 0% <0%> (ø)
lib/screens.js 0% <0%> (ø)
lib/constants/MigrationActionTypes.ts 100% <100%> (ø)
lib/reducers/migrationsReducer.ts 100% <100%> (ø)
lib/selectors/migrations.ts 100% <100%> (ø)
lib/selectors/attestations.js 98.46% <100%> (ø)
lib/sagas/keychain.js 83.5% <100%> (ø)
...as/migrations/InvalidateIdentityWithMissingKeys.ts 100% <100%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf3aba9...f56c480. Read the comment docs.

@pelle pelle changed the title Migrate all old Identities to ETHR DID (WIP) Migrate all old Identities to ETHR DID Jan 25, 2019
@pelle pelle requested a review from simonas-notcat January 25, 2019 01:16
pelle and others added 2 commits January 28, 2019 10:50
* RecoverySaga handles case where users identity is stored on phone

* Wire up Seed Recovery migration

* Fix a few issues on migration and recovery

* Fix final issues on seed recovery
@simonas-notcat simonas-notcat merged commit 71633f2 into develop Feb 28, 2019
@mirceanis mirceanis deleted the feature/migrate-all-old-identities branch January 22, 2020 11:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants