This repository has been archived by the owner on May 12, 2021. It is now read-only.
Support for *.uPort file type #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unzip this file and send it to your self via email, and try to open it with uport mobile app |
mirceanis
approved these changes
Nov 7, 2018
| <action android:name="android.intent.action.VIEW" /> | ||
| <action android:name="android.intent.action.EDIT" /> | ||
| <category android:name="android.intent.category.DEFAULT" /> | ||
| <data |
There was a problem hiding this comment.
just a heads-up,
The path-matcher in android is very primitive and won't match paths with multiple .
Additional <data> sections will have to be added at some point to compensate.
pelle
reviewed
Nov 12, 2018
| <key>public.filename-extension</key> | ||
| <string>uPort</string> | ||
| <key>public.mime-type</key> | ||
| <string>application/octet-stream</string> |
There was a problem hiding this comment.
shouldn't this be application/uport-vc or something similar?
There was a problem hiding this comment.
Honestly I have no idea. I just tested withapplication/octet-stream, and it worked fine. We can change it in the future if need to
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.