Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add windows-arm64 build #6

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add windows-arm64 build #6

wants to merge 1 commit into from

Conversation

hmartinez82
Copy link

@hmartinez82 hmartinez82 commented Jan 16, 2025 •
edited
Loading

hmartinez82
hmartinez82 commented Jan 16, 2025
View reviewed changes
.github/workflows/release.yml
mkdir ${{ env.PACKAGENAME }}
Copy-Item -Verbose -Path "README.md" -Destination "${{ env.PACKAGENAME }}"
Copy-Item -Verbose -Path "LICENSE" -Destination "${{ env.PACKAGENAME }}"
Copy-Item -Verbose -Path "build\Release\${{ needs.setup.outputs.APPNAME }}.exe" -Destination "${{ env.PACKAGENAME }}"
Copy-Item -Verbose -Path "C:\windows\system32\vcomp140.dll" -Destination "${{ env.PACKAGENAME }}"
Copy-Item -Verbose -Path "C:\windows\system32\vcomp140d.dll" -Destination "${{ env.PACKAGENAME }}"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We certainly can't do this for the ARM64 binary, so I fixed both x64 and arm64 to copy the OpenMP runtime using the correct folder which should be the one that comes with the toolset and not the one running in the OS.

Also, out of curiosity, why copy the Debug binary since upscayl-bin is only built in Release configuration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hmartinez82