Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Docker::API_VERSION to 1.11 to support /logs method #140

Closed
wants to merge 2 commits into from

Conversation

tombh
Copy link
Contributor

@tombh tombh commented Jun 2, 2014

Also added to README about version dependency and the new support for STDIN.

BTW the latest release of this gem made all my dreams come true :D 🌈

@tombh
Copy link
Contributor Author

tombh commented Jun 4, 2014

Just updated this PR with another version pin. This time for Rspec <3.0.0. I was the unlucky one to first surface the fact that Rspec 3 is now the default on Rubygems.

But now VCR is complaining about unregistered requests. I can't see why the small changes here are causing this...

@bfulton
Copy link
Contributor

bfulton commented Jun 4, 2014

@tombh, thanks! The API version is in the request URI like unix:///var/run/docker.sock/v1.11/ so we'll need to re-record the VCRs. Want to take a crack at it here?

@tombh
Copy link
Contributor Author

tombh commented Jun 4, 2014

Ah of course! Okay so I got passed the 404s just by deleting all the cassettes. And it's been whittled down to 15 failures. Some of which I can see are genuine changes introduced since 0.10. But the rest I don't know about. There's a lot from Excon complaining about malformed headers.

There's a gist here https://gist.github.com/tombh/5519b4a0d17d78a9fef7

I might not be the best person to pick through these.

@bfulton
Copy link
Contributor

bfulton commented Jun 4, 2014

@tombh got it, thanks for kicking it off. We'll take a look at these and also the rspec 3.0 issue today.

@tlunter tlunter mentioned this pull request Jun 26, 2014
@tlunter
Copy link
Contributor

tlunter commented Jun 26, 2014

Just opened #153 which should be all set and is based off of this.

@tlunter
Copy link
Contributor

tlunter commented Jun 26, 2014

@tombh this is finished and merged!

@tlunter tlunter closed this Jun 26, 2014
@tombh
Copy link
Contributor Author

tombh commented Jun 27, 2014

yay \o/ :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants