Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following your request at #14 (comment), I took a stab at speeding generateCombinationsImpl up a bit. My results are 3-4X speedup; the majority of the time is now spent
paste()
:ing combination names.Not an earth-shattering difference, but also not nothing perhaps?
Unit tests pass, but please verify that I've broken no assumptions.
5950X, 128 GB RAM, Fedora Linux 36, R 4.1.3, v1.11.0 / commit 12f306f
Before this PR:
With this PR: