Improve the Dockerfile #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `merge-gatekeeper` is necessarily hard-coded in the entrypoint, there's little value in extracting it to an environment variable; if we changed it, the entrypoint wouldn't exist. This commit therefore inlines it.
We don't need `ORG` and `REPO` in the container environment. This commit therefore redefines them as build arguments. This has the side benefit of being able to change them at build time, which could be useful for people using forks of this repo.
In order to reduce the number of image layers, this commit combines some environment variable definitions into a single step.
hlts2
approved these changes
Apr 11, 2022
rytswd
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes some small improvements to the Dockerfile in order to reduce the number of layers and build time, and to avoid polluting the container environment with unnecessary variables.