DX-1023: Add regex for base url #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests were failing because they got node end-of-life errors at vercel
|
fixed CI tests in this PR aswell. Here are the changes:
|
ogzhanolguncu
previously approved these changes
Jun 26, 2024
fahreddinozcan
approved these changes
Jun 26, 2024
ogzhanolguncu
approved these changes
Jun 26, 2024
renovate bot
referenced
this pull request
in inabagumi/shinju-date
Jul 4, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@upstash/redis](https://github.com/upstash/upstash-redis) | [`^1.31.6` -> `^1.32.0`](https://renovatebot.com/diffs/npm/@upstash%2fredis/1.31.6/1.32.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>upstash/upstash-redis (@​upstash/redis)</summary> ### [`v1.32.0`](https://github.com/upstash/redis-js/releases/tag/v1.32.0) [Compare Source](https://github.com/upstash/upstash-redis/compare/v1.31.6...v1.32.0) #### What's Changed - DX-1023: Add regex for base url by [@​CahidArda](https://github.com/CahidArda) in [https://github.com/upstash/redis-js/pull/1157](https://github.com/upstash/redis-js/pull/1157) - feat: add bitfield command by [@​lewxdev](https://github.com/lewxdev) in [https://github.com/upstash/redis-js/pull/1159](https://github.com/upstash/redis-js/pull/1159) - Resolve Auto Pipeline Arrappend Issue by [@​CahidArda](https://github.com/CahidArda) in [https://github.com/upstash/redis-js/pull/1165](https://github.com/upstash/redis-js/pull/1165) #### New Contributors - [@​lewxdev](https://github.com/lewxdev) made their first contribution in [https://github.com/upstash/redis-js/pull/1159](https://github.com/upstash/redis-js/pull/1159) **Full Changelog**: upstash/redis-js@v1.31.6...v1.32.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/inabagumi/shinju-date). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuOSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when an invalid url is passed to the client (without https like
eu1-flying-whale-434343.upstash.io), the client still tries to call the endpoint but gets invalild URL error. Instead of stopping there, it continues retrying with exponential backoff.For instance, in ratelimit, there is a 5 second timeout. Since the exponential backoff takes 12 seconds in total, error is never reflected to the console/network and the user simply gets the timeout response.
With this change, client raises an error right away and ratelimit doesn't return the default timeout response.