Do some type changes and cleanup #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mdumandag
commented
Nov 29, 2023
mdumandag
commented
- Changed the return type of geosearch commands from typed-dict to dataclass, to make it easier to use. Also, it conveys the optionality of the fields better now.
- Changed return types of sdiff, sunion, sinter, and smembers method to list from set. This eliminates extra set allocation for users doing iteration over the result. If they want, they can return the list into set themselves.
- Removed poetry.lock from the repo. We are a library, and the lock file will not be considered at all when the users install our library. If there is a problem in on of our depdencies during install, we would not be able to detect it at all due to lock file.
- Also applied isort and black into the codebase.
- Changed the return type of geosearch commands from typed-dict to dataclass, to make it easier to use. Also, it conveys the optionality of the fields better now. - Changed return types of sdiff, sunion, sinter, and smembers method to list from set. This eliminates extra set allocation for users doing iteration over the result. If they want, they can return the list into set themselves. - Removed poetry.lock from the repo. We are a library, and the lock file will not be considered at all when the users install our library. If there is a problem in on of our depdencies during install, we would not be able to detect it at all due to lock file. - Also applied isort and black into the codebase.
ytkimirti
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.