Format Redis database example in resources/
#43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>
| tls = "true" | ||
| multizone = "true" | ||
| region = "eu-west-1" | ||
| tls = true |
There was a problem hiding this comment.
terraform-provider-upstash/upstash/redis/database/resource.go
Lines 61 to 62 in 03511e2
| multizone = "true" | ||
| region = "eu-west-1" | ||
| tls = true | ||
| multizone = true |
There was a problem hiding this comment.
terraform-provider-upstash/upstash/redis/database/resource.go
Lines 54 to 55 in 03511e2
KeisukeYamashita
changed the title
resources/resources/
|
@fahreddinozcan @burak-upstash Sorry for the bothering, please take a look when you got chance 🙏 |
fahreddinozcan
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This was left over from #41 and needs formatting.
Also, I've noticed that some
Boolarguments are written here asString.It still works, but strongly typed examples are better.