Sample formatting using Black (Diff Review) #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
formatted the test_activation.py file with black, so that it can be compared in review DIFF.
|
Also I have not set the character limit on a line to 79 here, It is 90 I suppose. This can be changed so that side by side review is easy |
|
Seems reasonable to me. @Chronocook , any thoughts? |
|
Looks good, thanks! |
|
Can we go ahead with the manual formatting of the existing codebase and setting up the pre commit hooks ? |
|
Yup. Let's do it.
…On Thu, Oct 10, 2019, 11:44 AM Sharath Gangalapadu ***@***.***> wrote:
@bburns632 <https://github.com/bburns632> @Chronocook
<https://github.com/Chronocook>
Can we go ahead with the manual formatting of the existing codebase and
setting up the pre commit hooks ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#56?email_source=notifications&email_token=AF3FDS7M5CYTNPCY25JGRK3QN5LYPA5CNFSM4I7HF7R2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA5AJGY#issuecomment-540673179>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF3FDS56R3PUH7AQA6TBWTDQN5LYPANCNFSM4I7HF7RQ>
.
|
|
@bburns632 @Chronocook |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bburns632 @Chronocook
#46 Sample for the use of automated formatting using black and also formatting the codebase.
Here, I formatted the
tests/test_activation.pyfile using black. If you like the formatting here, we could do manual formatting for the codebase and then establish automated formatting.#hacktober2019