feat: warn when there are args but no placeholders

internal/dbtest/query_test.go

@@ -594,6 +594,9 @@ func TestQuery(t *testing.T) {
 		func(db *bun.DB) schema.QueryAppender {
 			return db.NewInsert().Model(new(SoftDelete2)).On("CONFLICT DO NOTHING")
 		},
+		func(db *bun.DB) schema.QueryAppender {
+			return db.NewInsert().Model(&Model{}).Returning("")
+		},
 	}
 
 	timeRE := regexp.MustCompile(`'\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}\.\d+(\+\d{2}:\d{2})?'`)

internal/dbtest/testdata/snapshots/TestQuery-mysql5-96

@@ -0,0 +1 @@
+INSERT INTO `models` (`id`, `str`) VALUES (DEFAULT, '')

internal/dbtest/testdata/snapshots/TestQuery-mysql8-96

@@ -0,0 +1 @@
+INSERT INTO `models` (`id`, `str`) VALUES (DEFAULT, '')

internal/dbtest/testdata/snapshots/TestQuery-pg-96

@@ -0,0 +1 @@
+INSERT INTO "models" ("id", "str") VALUES (DEFAULT, '')

internal/dbtest/testdata/snapshots/TestQuery-pgx-96

@@ -0,0 +1 @@
+INSERT INTO "models" ("id", "str") VALUES (DEFAULT, '')

internal/dbtest/testdata/snapshots/TestQuery-sqlite-96

@@ -0,0 +1 @@
+INSERT INTO "models" ("str") VALUES ('')

query_base.go

@@ -819,9 +819,11 @@ func (q *returningQuery) addReturningField(field *schema.Field) {
 
 func (q *returningQuery) hasReturning() bool {
 	if len(q.returning) == 1 {
-		switch q.returning[0].Query {
-		case "null", "NULL":
-			return false
+		if ret := q.returning[0]; len(ret.Args) == 0 {
+			switch ret.Query {
+			case "", "null", "NULL":
+				return false
+			}
 		}
 	}
 	return len(q.returning) > 0 || len(q.returningFields) > 0

query_insert.go

@@ -118,7 +118,7 @@ func (q *InsertQuery) WhereOr(query string, args ...interface{}) *InsertQuery {
 
 // Returning adds a RETURNING clause to the query.
 //
-// To suppress the auto-generated RETURNING clause, use `Returning("NULL")`.
+// To suppress the auto-generated RETURNING clause, use `Returning("")`.
 func (q *InsertQuery) Returning(query string, args ...interface{}) *InsertQuery {
 	q.addReturning(schema.SafeQuery(query, args))
 	return q

schema/sqlfmt.go

@@ -1,5 +1,11 @@
 package schema
 
+import (
+	"strings"
+
+	"github.com/uptrace/bun/internal"
+)
+
 type QueryAppender interface {
 	AppendQuery(fmter Formatter, b []byte) ([]byte, error)
 }
@@ -42,8 +48,13 @@ var _ QueryAppender = QueryWithArgs{}
 func SafeQuery(query string, args []interface{}) QueryWithArgs {
 	if args == nil {
 		args = make([]interface{}, 0)
+	} else if len(query) > 0 && strings.IndexByte(query, '?') == -1 {
+		internal.Warn.Printf("query %q has args %v, but no placeholders", query, args)
+	}
+	return QueryWithArgs{
+		Query: query,
+		Args:  args,
 	}
-	return QueryWithArgs{Query: query, Args: args}
 }
 
 func UnsafeIdent(ident string) QueryWithArgs {