fix: addng dialect override for append-bool (#695)

uptrace · Oct 27, 2022 · 338f2f0 · 338f2f0
1 parent bae46b4
commit 338f2f0
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 1 deletion.
diff --git a/dialect/mssqldialect/dialect.go b/dialect/mssqldialect/dialect.go
@@ -5,6 +5,7 @@ import (
 	"encoding/hex"
 	"fmt"
 	"log"
+	"strconv"
 	"strings"
 	"time"
 
@@ -116,6 +117,16 @@ func (*Dialect) AppendBytes(b, bs []byte) []byte {
 	return b
 }
 
+func (*Dialect) AppendBool(b []byte, v bool) []byte {
+	num := 0
+
+	if v {
+		num = 1
+	}
+
+	return strconv.AppendUint(b, uint64(num), 10)
+}
+
 func sqlType(field *schema.Field) string {
 	switch field.DiscoveredSQLType {
 	case sqltype.VarChar:

diff --git a/schema/append_value.go b/schema/append_value.go
@@ -183,7 +183,7 @@ func PtrAppender(fn AppenderFunc) AppenderFunc {
 }
 
 func AppendBoolValue(fmter Formatter, b []byte, v reflect.Value) []byte {
-	return dialect.AppendBool(b, v.Bool())
+	return fmter.Dialect().AppendBool(b, v.Bool())
 }
 
 func AppendIntValue(fmter Formatter, b []byte, v reflect.Value) []byte {

diff --git a/schema/dialect.go b/schema/dialect.go
@@ -29,6 +29,7 @@ type Dialect interface {
 	AppendString(b []byte, s string) []byte
 	AppendBytes(b []byte, bs []byte) []byte
 	AppendJSON(b, jsonb []byte) []byte
+	AppendBool(b []byte, v bool) []byte
 }
 
 //------------------------------------------------------------------------------
@@ -126,6 +127,10 @@ func (BaseDialect) AppendJSON(b, jsonb []byte) []byte {
 	return b
 }
 
+func (BaseDialect) AppendBool(b []byte, v bool) []byte {
+	return dialect.AppendBool(b, v)
+}
+
 //------------------------------------------------------------------------------
 
 type nopDialect struct {