Does (*UpdateQuery).Set() invalidate (*UpdateQuery).Column() ?

[nanmu42]

Hi,

Due to #621, I plan to manually update updated_at:

type OAuth2State struct {
	ID string `json:"id" bun:",pk"`

	CreatedAt time.Time `bun:",nullzero,notnull,skipupdate,default:current_timestamp" json:"createdAt"`
	UpdatedAt time.Time `bun:",nullzero,notnull,default:current_timestamp" json:"updatedAt"`

	Mode             OAuth2StateMode `json:"mode" bun:",notnull,nullzero"`
	Status           OAuth2Status    `json:"status" bun:",notnull"`
}

func (op Operator) UpdateOAuth2StateStatusByID(ctx context.Context, id string, status OAuth2Status) (err error) {
	state := OAuth2State{ID: id, Status: status}
	err = assertAffectedOneRow(op.db.NewUpdate().
		Model(&state).
		Column("status").
		Set("updated_at = current_timestamp").
		WherePK().
		Exec(ctx))
	return
}

But I found out the generated SQL only sets updated_at and status is ommited.

I digged into the source and got a little suprised:

bun/query_update.go

Lines 243 to 263 in efe03f4

	func (q *UpdateQuery) mustAppendSet(fmter schema.Formatter, b []byte) (_ []byte, err error) {
	b = append(b, " SET "...)
	if len(q.set) > 0 {
	return q.appendSet(fmter, b)
	}
	if m, ok := q.model.(*mapModel); ok {
	return m.appendSet(fmter, b), nil
	}
	if q.tableModel == nil {
	return nil, errNilModel
	}
	switch model := q.tableModel.(type) {
	case *structTableModel:
	b, err = q.appendSetStruct(fmter, b, model)
	if err != nil {
	return nil, err
	}

So using Set() results all Column() operation invalid? Is this by design?

Thanks and have a pleasant day!

[vmihailenco]

This is expected, but we could try to change this behavior if there is enough interest.