Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config.go): add connect_timeout to DSN parsable params #507

Merged
merged 1 commit into from
Apr 6, 2022
Merged

feat(config.go): add connect_timeout to DSN parsable params #507

merged 1 commit into from
Apr 6, 2022
+16 −0

Conversation

jessdwitch
Copy link
Contributor

Given a DSN using libpq's connect_timeout parameter, parses it as WithDialTimeout.

closes #505

@vmihailenco
Copy link
Member

Thanks!

@vmihailenco vmihailenco merged commit ddf0040 into uptrace:master Apr 6, 2022
@jessdwitch jessdwitch deleted the add-connect-timeout branch April 6, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pgdriver does not recognize connect_timeout parameter
2 participants
@jessdwitch @vmihailenco