Type system support #129
Merged
Type system support #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #129 +/- ##
=======================================
Coverage 83.11% 83.11%
=======================================
Files 11 11
Lines 308 308
Branches 80 80
=======================================
Hits 256 256
Misses 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ivojawer
commented
Feb 11, 2024
Comment on lines
+45
to
+51
| const message = `✘ Failed to build environment: ${error}` | ||
| logger.error({ | ||
| level: 'error', | ||
| files: files.map(file => file.name), | ||
| message, | ||
| }) | ||
| throw error |
There was a problem hiding this comment.
Lo puse aca, que es donde se buildea el environment
| message, | ||
| }) | ||
| connection.console.error(message) | ||
| connection.console.error(`✘ Failed to rebuild document: ${e}`) |
There was a problem hiding this comment.
Como ahora el buildEnvironment hace el log aca deje solo el mostrar el error al usuario
fdodino
approved these changes
Feb 11, 2024
Comment on lines
+45
to
+51
| const message = `✘ Failed to build environment: ${error}` | ||
| logger.error({ | ||
| level: 'error', | ||
| files: files.map(file => file.name), | ||
| message, | ||
| }) | ||
| throw error |
Comment on lines
+11
to
+24
| test('hover field', async () => { | ||
| await testHover( | ||
| hoverURI, | ||
| new Position(1, 8), | ||
| new Hover( | ||
| [ | ||
| new MarkdownString('\n```text\nField: Number\n```\n'), | ||
| new MarkdownString('\n```wollok\nconst x = 2\n```\n'), | ||
| ], | ||
| new Range(new Position(1, 2), new Position(2, 0)) | ||
| ) | ||
| ) | ||
| }) | ||
| }) |
|
RnR 🚀🚀🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resuelve item de uqbar-project/wollok-ts#187
Wollok? Un tipazo
Depende de uqbar-project/wollok-ts#203