Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Body editing #106

Merged
merged 10 commits into from
Sep 11, 2022
Merged

Body editing #106

merged 10 commits into from
Sep 11, 2022

Conversation

ivojawer
Copy link
Collaborator

@ivojawer ivojawer commented Aug 29, 2022

relates to: #82

Quedan dos cosas pendientes que no se si incluir en este PR:

  • Edicion de las sentencias.
  • El boton los problemas queda overrideado por el touchable opacity.
Screen.Recording.2022-08-28.at.21.50.13.mov

@ivojawer ivojawer requested a review from PalumboN August 29, 2022 01:01
Copy link
Collaborator

@PalumboN PalumboN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahí dejé un par de comments, ninguno bloqueante, excepto...

El boton los problemas queda overrideado por el touchable opacity

Qué significa? Que el botón no se puede presionar? Si es así entonces sí trataría de arreglarlo en este PR.

setup-tests.js Show resolved Hide resolved
src/components/sentences/SentencesEditor.tsx Show resolved Hide resolved
src/components/sentences/VisualSentence.tsx Outdated Show resolved Hide resolved
@ivojawer ivojawer merged commit 7647691 into dev Sep 11, 2022
@ivojawer ivojawer deleted the body-editing branch September 11, 2022 16:18
@ivojawer ivojawer mentioned this pull request Sep 11, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants