Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor navigation #78

Merged
merged 3 commits into from
Apr 24, 2022
Merged

Refactor navigation #78

merged 3 commits into from
Apr 24, 2022

Conversation

PalumboN
Copy link
Collaborator

@PalumboN PalumboN commented Apr 18, 2022 •
edited
Loading

Este PR apunta a #77

Arrega las navegaciones:

  • Ya no hay inner navigator, todas las pages están al mismo nivel. Es más simple
  • Los problems navegan a donde tienen que navegar
  • Entre el refactor y los renames toqué un montón de código, por eso lo mando en un PR aparte

Abrir issue para

@PalumboN
Fix navigation:
7069538 
- Bye inner navigator
- Fix problems navigation
- Renames
@PalumboN PalumboN requested a review from ivojawer April 18, 2022 16:35
@PalumboN PalumboN changed the title Fix navigation: Refactor navigation Apr 18, 2022
ivojawer
ivojawer approved these changes Apr 21, 2022
View reviewed changes
Copy link
Collaborator

@ivojawer ivojawer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amo este PR con mucha violencia

src/pages/EntityStack.tsx Outdated Show resolved Hide resolved
@PalumboN PalumboN merged commit a4b4abb into validations Apr 24, 2022
@PalumboN PalumboN deleted the fix-inner-navigators branch April 24, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivojawer ivojawer ivojawer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PalumboN @ivojawer