Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wollok-ts version #153

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Update wollok-ts version #153

wants to merge 1 commit into from

Conversation

julimr
Copy link

@julimr julimr commented Jul 25, 2022

Actualizamos la versión de wollok-ts de 3.0.6 a 3.1.1

@@ -18,7 +18,7 @@ const Inspect = () => {
try {
const expression = parse.Expression.tryParse(expressionText)
expression.forEach((node, parent) => {
if(parent) node.cache.set('parent()', parent)
if(parent) node.parent = parent
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FerRomMu si querés mira este cambio a ver si te parece que esta bien

@@ -10,7 +10,7 @@ export function nodeLabel(node: Node): string {
Method: node => `${node.name}/${node.parameters.length}`,
Field: node => `${node.name}`,
Variable: node => `${node.name}`,
Body: node => nodeLabel(node.parent()),
Body: node => nodeLabel(node.parent),
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FerRomMu este también

@julimr
Copy link
Author

julimr commented Jul 26, 2022

@FerRomMu
En este commit 0c405a4 estuvimos modificando cosas para que la version de wollok-ts 3.1.2 (la que ya no tiene io.wlk ni gameMirror.wlk en ts) funcione en wollok-run-client.
No hicimos PR porque es una rama inestable, ya que no pudimos poner en el package.json la version correspondiente de ts porque no esta publicada en npm. Por lo que package.json actual rompe.

La version wollok-ts 3.1.2, sería actualmente esta rama de wollok-ts con esta rama de wollok-language

@FerRomMu
Copy link

Cabe destacar que a mi este branch me falla (pesé a que a juli le anda). Específicamente me lanza un error en:

const highlight = (code: string) => currentNode.isSynthetic() ? code :
`${code.slice(0, currentNode.sourceMap!.start.offset)}<b id='current'>${code.slice(currentNode.sourceMap!.start.offset, currentNode.sourceMap!.end.offset)}</b>${code.slice(currentNode.sourceMap!.end.offset)}`

El error en cuestion es:
Type instantiation is excessively deep and possibly infinite.ts(2589) en todos los currentNodes

Lo pude solucionar así, que en realidad simplemente busca evitar que salte ese error, pero sigo haciendo lo mismo (dicho de otro modo es una especie de cambio sintáctico para que el compilador no me tire error):

const currentSourceMap = currentNode.sourceMap? currentNode.sourceMap : undefined
const highlight = (code: string) => currentNode.isSynthetic() ? code :
    `${code.slice(0, currentSourceMap!.start.offset)}<b id='current'>${code.slice(currentSourceMap!.start.offset, currentSourceMap!.end.offset)}</b>${code.slice(currentSourceMap!.end.offset)}`

Lo llamativo es que a @julimr no le fallaba el run-client y a mi sí (hasta que hice el cambio). Por eso no commitee el cambio.

@julimr julimr requested a review from nscarcella July 27, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants