Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List.get using rounding half up #2002

Merged
merged 5 commits into from
Jul 9, 2021
Merged

List.get using rounding half up #2002

merged 5 commits into from
Jul 9, 2021

Conversation

fdodino
Copy link
Collaborator

@fdodino fdodino commented Jul 1, 2021

@PalumboN te dejo un PR para redondear más humanamente el get.

@fdodino fdodino requested a review from PalumboN July 1, 2021 21:35
@fdodino fdodino added the Wollok Language Architectural issue: unification of wollok implementations label Jul 1, 2021
@fdodino fdodino added this to the Wollok 3.0.0 J milestone Jul 1, 2021
Copy link
Contributor

@PalumboN PalumboN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buenísimo @fdodino, esto está probado con uqbar-project/wollok-language#103 , no?
Deberíamos apuntar ese PR a 3.0? Y actualizar el submódulo de git acá? O esperamos a después del release?

@fdodino
Copy link
Collaborator Author

fdodino commented Jul 9, 2021

Buenísimo @fdodino, esto está probado con uqbar-project/wollok-language#103 , no?
Deberíamos apuntar ese PR a 3.0? Y actualizar el submódulo de git acá? O esperamos a después del release?

Ahí bajé los últimos cambios, rompieron algunos tests porque ahora Exception tiene un initialize... nada difícil, se arregla al toque.

@fdodino fdodino merged commit 8da93d3 into dev Jul 9, 2021
@fdodino fdodino deleted the fix-list-get branch July 9, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Wollok Language Architectural issue: unification of wollok implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants