Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscelanous minor changes to the codebase from #475 #554

Closed
wants to merge 4 commits into from
Closed

Miscelanous minor changes to the codebase from #475 #554

wants to merge 4 commits into from

Conversation

leogama
Copy link
Contributor

@leogama leogama commented Oct 4, 2022

To remove some of the cruft there.

@mmckerns mmckerns self-requested a review October 4, 2022 10:15
@mmckerns mmckerns added this to the dill-0.3.7 milestone Oct 23, 2022
mmckerns
mmckerns requested changes Feb 5, 2023
View reviewed changes
Copy link
Member

@mmckerns mmckerns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd approve, but the tests are failing. Ensure the tests pass, and let's pull this.

mmckerns
mmckerns reviewed Feb 5, 2023
View reviewed changes
dill/_dill.py
# Flags set by dump_module() is dill.session:
_refimported = False
_refonfail = False
_session = False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems _session shouldn't have been deleted -- it's still used in _locate_function and _save_module_dict.

@mmckerns mmckerns mentioned this pull request Feb 8, 2023
Merged
mmckerns added a commit that referenced this pull request Feb 8, 2023
@mmckerns @leogama
minor changes from PR #554 (#573)
4911aff 
* minor changes to the codebase from #475

* roll back some changes (moved to the refonfail PR)

* add _session to Pickler

---------

Co-authored-by: Leonardo Gama <leonardo.reis.gama@gmail.com>
@mmckerns
Copy link
Member

mmckerns commented Feb 8, 2023

obsoleted by #573

@mmckerns mmckerns closed this Feb 8, 2023
@mmckerns mmckerns added the voided label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmckerns mmckerns mmckerns requested changes

Assignees
No one assigned
Labels
voided
Projects
None yet
Milestone
dill-0.3.7
Development

Successfully merging this pull request may close these issues.
2 participants
@leogama @mmckerns