Drop _abc._abc_data from saving. #558
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng a clas implementing an ABCMeta class
|
@ryanthompson591: Thanks for submitting this PR. This seems to be a duplicate of a subset of #450. Note also your PR is currently failing for |
|
It looks like that PR does something similar to what I am doing, on line 2006 of _dill.py in their PR. @mmckerns - what do you suggest. Should I drop this PR since it might duplicate work already being done? |
I'm pretty sure it can be left to the other PR, and we can close this one. |
|
closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents an exception when havng a class implementing an ABCMeta class.
Please review this carefully to make sure it fits with dills workflow.
Background:
When pickling a class that inherits from metaclass=abc.ABCMeta dill crashes with an error:
This can be bypassed by dropping _abc_impl from the dictionary in save_type.