Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialize _abc_data. #585

Closed
wants to merge 1 commit into from
Closed

Serialize _abc_data. #585

wants to merge 1 commit into from

Conversation

tvalentyn
Copy link

@tvalentyn tvalentyn commented Mar 25, 2023 •
edited
Loading

Patch for #332

@tvalentyn
Copy link
Author

I came across a patch in my codebase for #332 . The credit for the patch belongs to @superbobry.

Looks like the patch does not work for pypy suites so keeping this as a draft for now. @mmckerns @anivegesana feel free to build upon it if you find it helpful.

@mmckerns
Copy link
Member

@tvalentyn: It's very much appreciated you submitting the patch. There's a reviewed PR with the same code that's ready to be merged pending some minor adjustments... so I'm going to mark this as a duplicate of #580, and close it. I'll get the other PR merged.

@mmckerns mmckerns closed this Mar 25, 2023
@mmckerns mmckerns added this to the dill-0.3.7 milestone Mar 25, 2023
@anivegesana
Copy link
Contributor

anivegesana commented Mar 25, 2023 •
edited
Loading

@mmckerns @tvalentyn Sorry for the delay. I got a little busy over the last two weeks and didn't find the time to split the remaining half of #450 into smaller PRs. I'll take care of #580 and will get the Enum PRs taken care of in the coming weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
dill-0.3.7
Development

Successfully merging this pull request may close these issues.
3 participants
@tvalentyn @mmckerns @anivegesana