Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UnpicklingError import for dill.load_session() to fix #648 #649

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Add UnpicklingError import for dill.load_session() to fix #648 #649

merged 1 commit into from
Feb 24, 2024

Conversation

lizy14
Copy link
Contributor

@lizy14 lizy14 commented Feb 22, 2024 •
edited
Loading

Summary

Fix #648

Checklist

Documentation and Tests

  • Added relevant tests that run with python tests/__main__.py, and pass.
  • Added relevant documentation that builds in sphinx without error.
  • Added new features that are documented with examples.
  • Artifacts produced with the main branch work as expected under this PR.

Release Management

  • Added "Fixes #NNN" in the PR body, referencing the issue (#NNN) it closes.
  • Added a comment to issue #NNN, linking back to this PR.
  • Added rationale for any breakage of backwards compatibility.
  • Requested a review.

@lizy14 lizy14 mentioned this pull request Feb 22, 2024
Closed
mmckerns
mmckerns approved these changes Feb 24, 2024
View reviewed changes
Copy link
Member

@mmckerns mmckerns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmckerns mmckerns merged commit 70f569b into uqfoundation:master Feb 24, 2024
3 checks passed
@mmckerns mmckerns added this to the dill-0.3.9 milestone Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmckerns mmckerns mmckerns approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
dill-0.3.9
Development

Successfully merging this pull request may close these issues.

dill.load_session() raises NameError: name 'UnpicklingError' is not defined
2 participants
@lizy14 @mmckerns