Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UART Read Data Sleep #101

Open
wants to merge 1 commit into
base: next_release
Choose a base branch
from

Conversation

samco182
Copy link
Contributor

What's in this pull request?

Adds an usleep invocation right after the read(fd, &buf, buf.count * MemoryLayout<CChar>.stride) call on readData function on the UART.swift class in order to be able to fully read all the available data on the serial port before returning.

Is there something you want to discuss?

For my SwiftyXBee library, I am checking whether there is available data on the serial port right before trying to read actual data from it; in order to avoid blocking my program in case there is no data available. Pretty often, I would be getting this crash: Fatal error: Index out of range: file /home/buildSwiftOnARM/swift/stdlib/public/core/ContiguousArrayBuffer.swift, line 369 when calling uart.hasAvailableData() immediately followed by uart.readData().
By trial an error, I found out that adding a 100ms sleep call right after the actual read method, would allow all the data to be read, so that Array(buf[0..<n]) at the return of the readData method wouldn't cause me a crash. I know it is not the most elegant solution, but it does its job.

Pull Request Checklist

  • I've added the default copyright header to every new file.
  • Every new file has been correctly indented, no tabs, 4 spaces (you can use swiftlint).
  • Verify that you only import what's necessary, this reduces compilation time.
  • Try to declare the type of every variable and constant, not using type inference greatly reduces compilation time.
  • Verify that your code compiles with the currently supported Swift version (currently 4.1.3)
  • You've read the contribution guidelines.

…fer.swift error crashes when trying to read data from serial port
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant