[MOBILE-4239] Fix Airship Actions running #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ulrico972
requested review from
jyaganeh,
ilitvinenko,
Apekka,
oristanovic and
khmMouna
Ulrico972
commented
Apr 5, 2024
ios/AirshipReactNative.swift
Outdated
| actionName, | ||
| value: try AirshipJSON.wrap(actionValue) | ||
| action["_name"] as! String, | ||
| value: action["_value"] is NSNull ? nil : try AirshipJSON.wrap(action["_value"]) |
There was a problem hiding this comment.
I had to make sure I pass nil if it's a NSNull.
Otherwise the JSON wrapping fails: the NSNull Object don't go through the guard else, is that normal @crow ?
public static func wrap(_ value: Any?, encoder: JSONEncoder = AirshipJSON.defaultEncoder) throws -> AirshipJSON {
guard let value = value else {
return .null
}
.
.
.
}
crow
approved these changes
Apr 5, 2024
rlepinski
reviewed
Apr 7, 2024
rlepinski
reviewed
Apr 7, 2024
rlepinski
reviewed
Apr 7, 2024
rlepinski
reviewed
Apr 8, 2024
rlepinski
reviewed
Apr 8, 2024
| /** | ||
| * Gets the event's interaction ID. | ||
| */ | ||
| get interactionId(): string | undefined { |
There was a problem hiding this comment.
do we need these changes?
There was a problem hiding this comment.
not particularly, I noticed we handle those in the proxy so I just added them
rlepinski
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Update the actions running code to encapsulate the action into a dictionary as the React conversion can't handle dynamic type like JsonValue directly.
Why are these changes necessary?
To handle actions with different value types.
How did you verify these changes?
Tested several actions making sure I test every values types possible.
New arch and old arch are working fine on Android. iOS is fine too.