-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use mblv9 #454
Conversation
@nllong The failing test has a Poetry deprecation warning. I don't know if that is related to the check failure or not. Can you check sometime at your convenience? I don't think it's urgent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Wonderful job, Nate! I ran the tests and replicated your results in terms of the # passing and failing, and ran the CHP system, district htg & clg with Teaser, district cooling (time series), and solar PV models in Dymola. They generally performed as expected, with a few specific notes below about things that are beyond the scope of this PR:
Regarding a few specific points:
- CHP model: The high HHW supply water temperatures seem to happen for short periods of time at conditions of low- or no mass flow, so I agree that it isn’t a problem. I noticed a possible area for future investigation in terms of the performance of the CHP model, and I'll submit an issue. (When I ran the simulation for a 2-month period, I noticed quite a few periods of negative mass flow at the supply temperature sensor (also corresponding to negative mass flow at the return mass flow rate sensor). )
- This branch is incorporating changes that will address the inconsistency in weather files between the CHW plant and building load models (such as Teaser) that currently occurs in the models generated by the tests: https://github.com/urbanopt/geojson-modelica-translator/tree/schema_mod_weather_file
d51ef6d
to
46d825d
Compare
@nllong Thank you for fixing the CI workflow! I could use some education on CI at some point in my career, it continues to be a mystery to me in general. Local tests all pass when the |
Aww, thanks, Nate! Wonderful job! @vtnate |
Co-authored-by: Nathan Moore <nathan.moore@nrel.gov>
Co-authored-by: Nathan Moore <nathan.moore@nrel.gov>
Break out build and simulate tests
@vtnate -- any reason not to merge once these tests pass? |
Nope, let's do it! 🚀 |
Any background context you want to provide?
The GMT should work with mainline MBL, to enable new capabilities as they are developed
Until we have a compiler for MSLv4, success for this PR will be defined as:
What does this PR accomplish?
Update templates, code, and test files to work with MBLv9
How should this be manually tested?
poetry run py.test
What are the relevant tickets?
#409