-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microgrid lines #467
Microgrid lines #467
Conversation
46d825d
to
99d2fbb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Nate,
I tried out the test, and it works perfectly to generate the model package, which then simulates without errors. I simulated the model, and also the ACLineMedium model from the buildings library, and there were some elements of the results that seemed unexpected to me, but they were the same in both cases. It's possible that I'm misinterpreting, or using different model inputs would generate more expected results. Here were those two items that I noted about the model results , for both this model and the original one in the MBL, (which I don't think have anything to do with your PR, so this is tangential):
-
There's no power dissipated thru any of the resistors, despite there being current thru the line, and a non-zero resistance value assigned.
-
The phase angle vector (in radians, according to the documentation) appears to be being reported cumulatively, and as a scalar:
Nate and Nick, do either of you have any ideas on what might explain these two things? Thanks! @vtnate @nllong
Can you plot the current and voltage too? This does seem strange, but it is good that MBL and GMT are resulting in the same. The cumulative phase angle is also strange... should be instantaneous. |
Hi Nick, and Nate, @nllong @vtnate These were representative of the voltage values in the lines, with the other element of the voltage vector at the node being zero. Also, there seem to be some slight variations in current values between the GMT model (the higher value shown here) and the underlying MBL model, that aren't explained by different line numbering. I haven't id'd any explanation for that as yet. \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on Mingzhe's comments, it appears that the model performed as expected. : )
Any background context you want to provide?
The ACLine.mot template for microgrid power lines doesn't handle the wires properly. This fixes it so the template builds a model the way I expect.
What does this PR accomplish?
How should this be manually tested?
poetry run pytest tests/GMT_Lib/test_gmt_lib.py -m 'not simulation'
What are the relevant tickets?
Resolves #466