Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microgrid lines #467

Merged
merged 14 commits into from
Aug 22, 2022
Merged

Microgrid lines #467

merged 14 commits into from
Aug 22, 2022

Conversation

vtnate
Copy link
Contributor

@vtnate vtnate commented May 17, 2022

Any background context you want to provide?

The ACLine.mot template for microgrid power lines doesn't handle the wires properly. This fixes it so the template builds a model the way I expect.

What does this PR accomplish?

  • Update microgrid sys-param test file with modern output from opendss
  • Fixes bugs in build-sys-param code that crashed if reopt data wasn't available
  • Maps from OpenDSS output to MBL wires
  • Adds wires to the line properly

How should this be manually tested?

  1. poetry run pytest tests/GMT_Lib/test_gmt_lib.py -m 'not simulation'
  2. Load Dymola with MSLv4, MBLv9, and tests/GMT_Lib/output/DistributionLines/ACLine*.mo
  3. Simulate the model in Dymola
  4. Inspect output of simulation

What are the relevant tickets?

Resolves #466

@vtnate vtnate linked an issue May 17, 2022 that may be closed by this pull request
3 tasks
@nllong nllong force-pushed the use-mblv9 branch 3 times, most recently from 46d825d to 99d2fbb Compare May 20, 2022 03:34
Base automatically changed from use-mblv9 to develop May 25, 2022 14:17
@vtnate vtnate added bug Something isn't working enhancement New feature or request labels Jun 30, 2022
@vtnate vtnate marked this pull request as ready for review July 14, 2022 22:00
@vtnate vtnate requested a review from amyeallen1 July 15, 2022 21:04
Copy link

@amyeallen1 amyeallen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Nate,
I tried out the test, and it works perfectly to generate the model package, which then simulates without errors. I simulated the model, and also the ACLineMedium model from the buildings library, and there were some elements of the results that seemed unexpected to me, but they were the same in both cases. It's possible that I'm misinterpreting, or using different model inputs would generate more expected results. Here were those two items that I noted about the model results , for both this model and the original one in the MBL, (which I don't think have anything to do with your PR, so this is tangential):

  1. There's no power dissipated thru any of the resistors, despite there being current thru the line, and a non-zero resistance value assigned.
    image

  2. The phase angle vector (in radians, according to the documentation) appears to be being reported cumulatively, and as a scalar:
    image

Nate and Nick, do either of you have any ideas on what might explain these two things? Thanks! @vtnate @nllong

@nllong
Copy link
Member

nllong commented Aug 5, 2022

Hi Nate, I tried out the test, and it works perfectly to generate the model package, which then simulates without errors. I simulated the model, and also the ACLineMedium model from the buildings library, and there were some elements of the results that seemed unexpected to me, but they were the same in both cases. It's possible that I'm misinterpreting, or using different model inputs would generate more expected results. Here were those two items that I noted about the model results , for both this model and the original one in the MBL, (which I don't think have anything to do with your PR, so this is tangential):

  1. There's no power dissipated thru any of the resistors, despite there being current thru the line, and a non-zero resistance value assigned.
    image
  2. The phase angle vector (in radians, according to the documentation) appears to be being reported cumulatively, and as a scalar:
    image

Nate and Nick, do either of you have any ideas on what might explain these two things? Thanks! @vtnate @nllong

Can you plot the current and voltage too? This does seem strange, but it is good that MBL and GMT are resulting in the same. The cumulative phase angle is also strange... should be instantaneous.

@amyeallen1
Copy link

amyeallen1 commented Aug 8, 2022

Hi Nick, and Nate, @nllong @vtnate
Thanks for considering this. Here are plots of current at port n (the other port is generally equal and opposite). These two lines are representative of the others.

image

image

These were representative of the voltage values in the lines, with the other element of the voltage vector at the node being zero.

image

Also, there seem to be some slight variations in current values between the GMT model (the higher value shown here) and the underlying MBL model, that aren't explained by different line numbering. I haven't id'd any explanation for that as yet. \

image

Copy link

@amyeallen1 amyeallen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on Mingzhe's comments, it appears that the model performed as expected. : )

@amyeallen1 amyeallen1 merged commit 2f37857 into develop Aug 22, 2022
@amyeallen1 amyeallen1 deleted the microgrid-lines branch August 22, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get ACLine template working
3 participants