Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redeclare the teaser model to use buildings.media.air medium #473

Merged
merged 1 commit into from
May 25, 2022

Conversation

nllong
Copy link
Member

@nllong nllong commented May 25, 2022

Any background context you want to provide?

Auto-generated TEASER models used the incorrect medium.

What does this PR accomplish?

  • uses new release candidate of modelica builder to replace the redeclaration of the medium in the teaser models

How should this be manually tested?

  • run pytest and take any of the teaser test models and run in dymola.

What are the relevant tickets?

Fixes #38
^-- that was an old ticket, finally addressed!

Screenshots (if appropriate)

This code:
image

results in an updated model shown in Dymola here:
image

@nllong nllong requested a review from vtnate May 25, 2022 17:53
Copy link
Contributor

@vtnate vtnate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected, and the models run in Dymola, so I'm taking that as proof that the modelica-builder PR is doing what we want. Badda boom badda bing!

@nllong nllong merged commit 047d30f into develop May 25, 2022
@nllong nllong deleted the redeclare-buidings-medium branch May 25, 2022 20:02
@vtnate vtnate added the enhancement New feature or request label Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using medium model from MBL
2 participants