Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple gain for distribution and ghx mass flow rates #600

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Decouple gain for distribution and ghx mass flow rates #600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26ce59a
decouple gain for distribution and ghx mass flowrates
nllong Nov 17, 2023
b5c5cf2
set building load multiplier to 1
nllong Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions geojson_modelica_translator/modelica/GMT_Lib/DHC/DHC_5G_partial.mot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ within {{ data['project_name'] }}.Districts;{% raw %}
partial model PartialSeries "Partial model for series network"
extends Modelica.Icons.Example;
package Medium = Buildings.Media.Water "Medium model";
constant Real facMul = 10
constant Real facMul = 1
"Building loads multiplier factor";
parameter Real dpDis_length_nominal(final unit="Pa/m") = 250
"Pressure drop per pipe length at nominal flow rate - Distribution line";
Expand Down Expand Up @@ -277,9 +277,14 @@ equation
Documentation(revisions="<html>
<ul>
<li>
November 16, 2023, by Nicholas Long:<br/>
Default the facMul to 1. The loads for the GMT are coming from real buildings
and we do not need to multiply the QHea/QCoo.
nllong marked this conversation as resolved.
Show resolved Hide resolved
</li>
<li>
April 12, 2023, by Nicholas Long:<br/>
Templatized for direct use in GMT with n-building connectors.
<li>
</li>
<li>
November 16, 2022, by Michael Wetter:<br/>
Set correct nominal pressure for distribution pump.
Expand Down
27 changes: 17 additions & 10 deletions geojson_modelica_translator/modelica/GMT_Lib/DHC/DHC_5G_waste_heat_GHX_variable.mot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,12 @@ model district
TMax=290.15,
use_temperatureShift=false) "Main pump controller"
annotation (Placement(transformation(extent={{-280,-70},{-260,-50}})));
Buildings.Controls.OBC.CDL.Continuous.MultiplyByParameter gai(k=datDes.mPumDis_flow_nominal)
"Scale with nominal mass flow rate"
Buildings.Controls.OBC.CDL.Continuous.MultiplyByParameter gaiPumDis(k=datDes.mPumDis_flow_nominal)
"Scale with nominal mass flow rate for distribution pump"
annotation (Placement(transformation(extent={{-240,-70},{-220,-50}})));
Buildings.Controls.OBC.CDL.Continuous.MultiplyByParameter gaiPumSto(k=datDes.mSto_flow_nominal)
"Scale with nominal mass flow rate for storage GHX pump"
annotation (Placement(transformation(extent={{-240,-112},{-220,-92}})));
equation
connect(masFloDisPla.y, pla.mPum_flow) annotation (Line(points={{-229,20},{
-184,20},{-184,4.66667},{-161.333,4.66667}},
Expand All @@ -47,12 +50,10 @@ equation
connect(TColWat.y, bui.TColWat) annotation (Line(points={{-138,160},{-40,160},
{-40,164},{-8,164},{-8,168}},
color={0,0,127}));
connect(pumDis.m_flow_in, gai.y)
annotation (Line(points={{68,-60},{-218,-60}},
color={0,0,127}));
connect(conPum.y, gai.u)
annotation (Line(points={{-258,-60},{-242,-60}},
color={0,0,127}));
connect(pumDis.m_flow_in, gaiPumDis.y)
annotation (Line(points={{68,-60},{-218,-60}}, color={0,0,127}));
connect(conPum.y, gaiPumDis.u)
annotation (Line(points={{-258,-60},{-242,-60}}, color={0,0,127}));
connect(dis.TOut, conPum.TMix) annotation (Line(points={{22,134},{30,134},{30,
120},{-300,120},{-300,-54},{-282,-54}},
color={0,0,127}));
Expand All @@ -67,8 +68,10 @@ equation
connect(TDisWatSup.T, conPum.TSouOut[2]) annotation (Line(points={{-91,20},{-100,
20},{-100,60},{-296,60},{-296,-65},{-282,-65}},
color={0,0,127}));
connect(gai.y, pumSto.m_flow_in) annotation (Line(points={{-218,-60},{-180,-60},
{-180,-68}}, color={0,0,127}));
connect(gaiPumSto.u, gaiPumDis.u) annotation (Line(points={{-242,-102},{-248,
-102},{-248,-60},{-242,-60}}, color={0,0,127}));
connect(gaiPumSto.y, pumSto.m_flow_in) annotation (Line(points={{-218,-102},{
-210,-102},{-210,-62},{-180,-62},{-180,-68}}, color={0,0,127}));
annotation (
Diagram(
coordinateSystem(preserveAspectRatio=false, extent={{-360,-260},{360,260}})),
Expand All @@ -91,6 +94,10 @@ allowed loop temperature, then the mass flow rate is reduced to save pump energy
</html>", revisions="<html>
<ul>
<li>
November 17, 2023, by Nicholas Long:<br/>
Break out the mass flow rate gain multiplier for the GHX/Storage.
nllong marked this conversation as resolved.
Show resolved Hide resolved
</li>
<li>
November 1, 2023, by Nicholas Long:<br/>
Templatized for direct use in GMT with n-building connectors.<br/>
Changes include: removing dymola run command tied to MBL path, adding
Expand Down