Enable more detail when specifying district types #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingWang-CUB
approved these changes
Mar 11, 2024
nllong
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
BREAKING CHANGE - CLI
Our existing technique for specifying which type of district we're modeling (4G, 5G, 5G with GHE, Steam) was not very simple or extensible. This should make it both more clear and better able to handle future additions. @nllong Let's talk about how we name the district types/generations.
What does this PR accomplish?
--ghe) to be a string from the user specifying what type of district they are modelingHow should this be manually tested?
CI is sufficient
What are the relevant tickets?
Screenshots (if appropriate)