Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code documentation cleanup #631

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Code documentation cleanup #631

merged 2 commits into from
Apr 22, 2024

Conversation

nllong
Copy link
Member

@nllong nllong commented Apr 10, 2024

Any background context you want to provide?

Just making the docstrings consistent.

@nllong nllong requested a review from vtnate April 10, 2024 19:00
Copy link
Contributor

@vtnate vtnate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standardization ftw! Do we want to go farther in improving docstrings at this time? If we wanna get crazy and do code examples in docstrings, at least ruff knows how to handle that.

"""
Create system parameters file using uo_sdk output
"""Create system parameters file using uo_sdk output
#FIXME: Formatting of the args...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What needs to be formatted in the cli args?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The args in the doctoring need to be formatted differently...

hit cmd-shift-2 after the function and it should stub it out for you (in VScode)

@vtnate vtnate merged commit 5aeba32 into develop Apr 22, 2024
10 checks passed
@vtnate vtnate deleted the small-doc-cleanup branch April 22, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants