-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds method to process modelica results #646
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run pre-commit and address the linting & formatting changes.
Overall it's not clear to me what this command is for. Will you add more context to the PR description (and perhaps a bit to the cli command description) explaining what the output is, why someone would use this command, and how to interpret it?
This needs to be incorporated |
what is the pre commit command? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the tests all pass, but there are still linting issues found by Ruff in pre-commit. Please address those as well as my comments here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making use of results! ❤️ This is fantastic. In FY25 we should incorporate some of Nicholas' work from the UO_DES repo to expand this even more.
Objective :
This cli call takes the modelica folder created and run previously as an argument. It then reads the .mat file and queries timeseries results for heating, cooling electricity consumption of heat pumps, ets pump electricity consumption, pump associated with building electricity consumption loop pump electricity consumption and heat pump sizing for the GHP network.
This uses methods from the modelica buildingspy library to query results. https://simulationresearch.lbl.gov/modelica/buildingspy/
To test :
Use
uo_des des-process
<modelica_model_name>`Run
poetry run pytest tests poetry run pytest .\tests\geojson_modelica_translator\test_results_ghp.py
Check the "geojson-modelica-translator\tests\geojson_modelica_translator\data\modelica_5\modelica_5.Districts.DistrictEnergySystem_results\modelica_5.Districts.DistrictEnergySystem_result.csv" file created with results queried for REopt GHP at 15 minute intervals.