Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to MBLv11 #649

Merged
merged 37 commits into from
Oct 28, 2024
Merged

Upgrade to MBLv11 #649

merged 37 commits into from
Oct 28, 2024

Conversation

vtnate
Copy link
Contributor

@vtnate vtnate commented Aug 15, 2024

Any background context you want to provide?

LBNL has improved the MBL, and we can take advantage of it. DHC has been upgraded from Experimental to a regular group, so many paths have changed. Some models have been renamed, some have been deleted.

The MBL release notes should document what has changed.

The MBL maintainers have a conversion script that can help update models, but I don't know how to use it.

What does this PR accomplish?

  • Install MBLv11 in the Dockerfile
  • Refactor templates to work with MBLv11
  • Change compile_with_msl test to point to correct location of generated fmu
    • I don't know why this changed location. Maybe that's not new?

How should this be manually tested?

  1. Make a docker image from this branch
  2. Point to the new image in this line
  3. Run all simulation tests

@vtnate vtnate added the dependencies Pull requests that update a dependency file label Aug 15, 2024
@vtnate vtnate self-assigned this Aug 15, 2024
@vtnate vtnate changed the base branch from develop to bump-om August 15, 2024 20:33
@vtnate vtnate requested a review from nllong October 15, 2024 17:24
@vtnate vtnate marked this pull request as ready for review October 15, 2024 17:55
Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, what an upgrade!

I'll build a docker image and push to make CI happy.

@vtnate vtnate merged commit c607ba4 into bump-om Oct 28, 2024
10 checks passed
@vtnate vtnate deleted the mblv11 branch October 28, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants