Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use feature ids in load names instead of simple_uuid #652

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

vtnate
Copy link
Contributor

@vtnate vtnate commented Sep 3, 2024

Any background context you want to provide?

This will simplify access to results of Modelica simulations by naming the Modelica variables with the geojson_id of the load (building). Future work should do the same thing for borefields when modeling GHEs.

What does this PR accomplish?

Update self.id for the loads to use the geojson_id instead of generating a simple_uuid. We retain simple_uuid for objects that aren't being supplied by the geojson file, such as networks, couplings, ETSs, etc.

How should this be manually tested?

CI is sufficient

What are the relevant tickets?

Resolves #645

Screenshots (if appropriate)

@vtnate vtnate added the enhancement New feature or request label Sep 3, 2024
@vtnate vtnate self-assigned this Sep 3, 2024
@tanushree04 tanushree04 self-requested a review September 4, 2024 15:37
@tanushree04
Copy link
Collaborator

tanushree04 commented Sep 4, 2024

Looks great @vtnate , does this take care of all modelica variables for buildings in the TimeSerLoa_ format and adds the building feature instead of the UUID?

@vtnate
Copy link
Contributor Author

vtnate commented Sep 4, 2024

Looks great @vtnate , does this take care of all modelica variables for buildings in the TimeSerLoa_ format and adds the building feature instead of the UUID?

That's the intent, yes. Can you generate a model from this branch and confirm that it provides the info you need?

Copy link
Collaborator

@tanushree04 tanushree04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I created a new modelica model and ran the results from my script, the variables are now named as per the feature ID, great work!

@vtnate vtnate merged commit b869a29 into develop Sep 4, 2024
10 checks passed
@vtnate vtnate deleted the use-feature-ids branch September 4, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use building IDs from GeoJSON / Find a way to link Modelica outputs to GeoJSON Feature IDS
2 participants