Use feature ids in load names instead of simple_uuid #652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
This will simplify access to results of Modelica simulations by naming the Modelica variables with the geojson_id of the load (building). Future work should do the same thing for borefields when modeling GHEs.
What does this PR accomplish?
Update
self.id
for the loads to use the geojson_id instead of generating a simple_uuid. We retain simple_uuid for objects that aren't being supplied by the geojson file, such as networks, couplings, ETSs, etc.How should this be manually tested?
CI is sufficient
What are the relevant tickets?
Resolves #645
Screenshots (if appropriate)