Clean up sys-param code that reads parameters #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nllong
approved these changes
Oct 27, 2024
|
|
||
| if len(results) == 1: | ||
| # If only one value, then return that value and not a list of values | ||
| # If only one value, then return that value and not a list of values. | ||
| results = results[0] |
There was a problem hiding this comment.
I don't like that we do this. I think we should always return a list. I don't know why I did this (I'm guilty for it). I think I was following another API pattern. Regardless, leave it as is, otherwise it will break lots of things.
| results = results[0] | ||
| elif len(results) == 0: | ||
| return default_value | ||
| return None |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
A while ago we removed the 'defaults' section of sys-param files. This removes the code for reading those sections.
What does this PR accomplish?
Refactor the
get_paramcode in system_parameters.py to remove references to defaults which haven't existed for some time.How should this be manually tested?
CI is sufficient
What are the relevant tickets?
Resolves #495