-
Notifications
You must be signed in to change notification settings - Fork 57
Conversation
I resolved a merge conflict in Clay by checking both the error in the |
Broke :aqua-behn. Fix incoming. |
@philipcmonk I think I fixed Aqua; we'll see what the tests say. I added |
Tests passed; ready for review. |
@belisarius222, since this is going into |
@joemfb I'm down, although I think we should get this in as-is first. I think it'll be a little cleaner that way, although I could be convinced otherwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. My only question is whether there are apps that will choke when given an erroring wake. This is still strictly an improvement, though.
It looks to me like all the apps that set timers will fail if the are called with an error |
This sets the groundwork for future work for vanes to handle async errors. I just added stubs to the various vanes for now, but at least they now have the error information.
A
|reset
passed, but I have not done more detailed testing on this. Not sure if there's a convenient way to test. Maybe pH?