This repository has been archived by the owner on Aug 14, 2019. It is now read-only.
no-op on bad ames packet mugs #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be cleaner if we changed +bite to produce a (unit cake) instead of inlining it. If it's only gonna be here for a few days, then this is fine, but otherwise we shouldn't duplicate the code. |
|
Fair enough, I assumed +bite was called elsewhere so I didn't want to disturb it, but I was mistaken. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly just to alleviate some pain while doing devops on zod, which continually gets spammed from ships in past eras, with the correct ames protocol number but bad packet mug hashes.
Normally I just edit the ames on zod to include this logic but I see no reason why it shouldn't go into the repo.