This repository has been archived by the owner on Aug 14, 2019. It is now read-only.
reverted nap:to bugfix #1144
Merged
reverted nap:to bugfix #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No hard feelings :) Hope that this will be useful eventually... |
Can someone give a tldr of how ames depends on it being broken? |
|
I think the short answer is we don't know. It crashed a lot, and stack
traces revealed that at some point Ames's :puq packet queue had three
elements but its counter (:nif) said two.
There are a few places where Ames does bespoke treap frobnication to use a
+qeu as a priority queue, so presumably the dependency on +nap's old
behavior is somewhere in one of those places.
On Sun, Apr 14, 2019 at 3:52 AM Fang ***@***.***> wrote:
Because ames depends on it being broken.
Can someone give a tldr of how ames *depends* on it being broken?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1144 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA1Y9QNC0HynaI1deIK2CTETcJEdF2Z1ks5vgwh5gaJpZM4cuUAu>
.
--
—
~rovnys-ricfer
https://urbit.org
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts this bugfix: #1128 Because ames depends on it being broken.
With apologies to @yosoyubik