Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

greeting: point to new invite screen #389

Merged
merged 2 commits into from
Feb 26, 2020
Merged

greeting: point to new invite screen #389

merged 2 commits into from
Feb 26, 2020

Conversation

Fang-
Copy link
Member

@Fang- Fang- commented Feb 6, 2020

The INVITE route got renamed to INVITE_COHORT during #369. Just INVITE points to the sigil page somehow...

@Fang- Fang- requested a review from liam-fitzgerald February 6, 2020 18:32
@Fang-
Copy link
Member Author

Fang- commented Feb 6, 2020

On reflection, maybe this link should be removed entirely? We show the invite functionality on the point overview page now, which is where this would show up.

@liam-fitzgerald
Copy link
Member

Remove is probably the way to go

Copy link
Member

@liam-fitzgerald liam-fitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove go invite

Invite is now quite prominent on the Point.js page, where greeting gets shown.
@Fang-
Copy link
Member Author

Fang- commented Feb 26, 2020

Oops! Busy times are no excuse to let something this simple slip down the cracks.

Went and removed the entire thing.

Copy link
Member

@liam-fitzgerald liam-fitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Fang- Fang- merged commit a46fd36 into master Feb 26, 2020
@Fang- Fang- deleted the m/greeting-invite branch February 26, 2020 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants