Hosting RC #406
Hosting RC #406
Conversation
|
Trying to review this properly.
What do I use for this? ylem? Can I run that strictly locally somehow? |
There was a problem hiding this comment.
Preliminary review. No comment on the hosting stuff yet because (it's late and) I haven't been able to test-run it yet.
- Is missing a still-pending azimuth-js upgrade in package.json. @jtobin release, pretty please? (:
- The new-style inline transaction isn't used consistently?
- Some of these are registering as file moves/renames, but not all of them. There's no deleted files. Can we make sure we clean up unused/deprecated views etc?
liam-fitzgerald
force-pushed
the
hosting-rc
branch
from
e2b1190 to
9e3a8f0
Compare
|
bump can I get another pass @Fang- |
LoginButton component POSTs the login request to a given point
adds localHosting hook, to check whether or not the ship is self hosted.
There was a problem hiding this comment.
This seems fine now as far as the code is concerned. @jyng may have design comments, and it came up during interface meeting yesterday that neither of us known what the launch procedure for this is. Things seem more or less ready, but we want to roll this out to a select number of people at first. Does that mean a secondary hosted version?
One click login
|
Well the hosting backend isn't ready for deploy, so we can just deploy this PR as is (hosting disabled) and deal with enabling hosting when the backend is ready |
|
Is anything keeping this from being merged? I'm antsy for the "change sponsor" as a part of Bridge functionality |
|
Nothing as far as I'm aware. I'd like to get this in with hosting disabled and then we can discuss hosting more in the PR where it gets enabled. |
|
Basically, nobody knows how we plan to stage these releases but AA; I asked if we could pause the two days instead of going full steam ahead in that case. The escape functionality being in this RC is unfortunate, as it then becomes one of my hostages.
…Sent from my iPhone
On Apr 9, 2020, at 8:20 PM, Liam Fitzgerald ***@***.***> wrote:
Nothing as far as I'm aware. I'd like to get this in with hosting disabled and then we can discuss hosting more in the PR where it gets enabled.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
When is the adoption functionality being merged? @vvisigoth @liam-fitzgerald |
|
How difficult would it be to pull out/backport the residents/sponsor functionality, @liam-fitzgerald? |
|
not super difficult, but I'd like to just disable hosting and merge this as-is |
|
That works too, afaic. I don't think @vvisigoth would object at this point. Speak up now, or forever hold your peace. |
|
Yeah, disable and morge. I'm getting a brief from Bren on this tomorrow,
but I don't want to couple this.
—
~poldec-tonteg
http://urbit.org
…On Wed, Apr 29, 2020 at 3:22 PM Fang ***@***.***> wrote:
That works too, afaic. I don't think @vvisigoth
<https://github.com/vvisigoth> would object at this point. Speak up now,
or forever hold your peace.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#406 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMJBY37NWGOCD4VOMIBT23RPCSBDANCNFSM4LA4VR2A>
.
|
|
Ping |
|
@liam-fitzgerald can you disable access to the hosting page at your earliest convenience, so we can finally get this merged? |
|
When is adoption functionality being merged? 🧐 |
|
Ping? |
|
Will be in by end of week! sorry for the delay |
|
ready to morge and deploy! @Fang- |
|
Alright let's get cooking. Update: deployed! |
Stuff to know:
Issues blocking merge:
I apologise for the size of the PR. Moving forward, whilst the backend auth stuff is finished I'll base new branches off this branch and PR against it as a lot of the upcoming work involves redesigns that most likely won't merge well.