New login screen to make non-master ticket logins easier to navigate #409
Conversation
jyng
commented
Mar 10, 2020
•
jyng
commented
|
Surely just trailing ellipses from “Hardware Wallet…” is better than “etc.” in a button?
—
~haddef-sigwen
https://urbit.org
… On Mar 9, 2020, at 10:43 PM, Jimmy ***@***.***> wrote:
You can view, comment on, or merge this pull request online at:
#409
Commit Summary
• login: header center
• login: prettier spacing fix
• login.js: removing tabs replacing with buttons
• login.js: add inline toggle input for ticket login
• other.js: cleaning up my typography descriptions,login.js: small copy changes
• inputs.js: master ticket placeholder show/hide
• inputs.js: using dots instead of asterik for placeholder
File Changes
• M package-lock.json (41)
• A src/assets/secret-hidden.svg (17)
• A src/assets/secret-show.svg (4)
• M src/components/View.js (6)
• M src/form/Inputs.js (7)
• M src/indigo-react/components/CheckboxInput.js (18)
• M src/indigo-react/components/Input.js (13)
• M src/indigo-react/components/ToggleInput.js (5)
• M src/lib/routeNames.js (1)
• M src/lib/router.js (2)
• M src/lib/useEthereumTransaction.js (1)
• M src/views/Invite/Cohort.js (2)
• M src/views/Invite/Email.js (2)
• M src/views/Login.js (77)
• M src/views/Login/Keystore.js (4)
• M src/views/Login/Ledger.js (5)
• M src/views/Login/Metamask.js (5)
• M src/views/Login/Mnemonic.js (2)
• M src/views/Login/Other.js (25)
• M src/views/Login/PrivateKey.js (2)
• M src/views/Login/Ticket.js (116)
• M src/views/Login/Trezor.js (6)
Patch Links:
• https://github.com/urbit/bridge/pull/409.patch
• https://github.com/urbit/bridge/pull/409.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Yeah 'etc...' seems a bit odd. 'Other options (Metamask, Ledger, etc)' or similar. |
|
YEAH
—
~poldec-tonteg
http://urbit.org
…On Mon, Mar 9, 2020 at 7:57 PM Galen Wolfe-Pauly ***@***.***> wrote:
Yeah 'etc...' seems a bit odd. 'Other options (Metamask, Ledger, etc)' or
similar.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#409?email_source=notifications&email_token=AAMJBY5NCEG3IKLZUVWR5BTRGW3BZA5CNFSM4LEVR7N2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOJZVMQ#issuecomment-596875954>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMJBY2G7AT2V4UMOYCKDOTRGW3BZANCNFSM4LEVR7NQ>
.
|
|
Otherwise, i think this is vast improvement, thnx. Approved based on changing ellipsis. |
|
Edited |
| onClick={() => setisOther(false)} | ||
| full | ||
| className="t-center underline f6 mt8"> | ||
| Back |
There was a problem hiding this comment.
Should this just say "Master Ticket" or similar instead, to have more symmetry with the "Metamask, Mnemonic..." button?
| <Grid.Item full onClick={goToActivate} className="mv10 t-center f6"> | ||
| <span className="gray4">New Urbit ID? </span> | ||
| <LinkButton>Activate</LinkButton> | ||
| </Grid.Item> |
There was a problem hiding this comment.
Not sure why we don't just show this on both pages (ie regardless of isOther), but I can see how it's only strictly needed for the landing conditions.
(Also the space after "ID?" bother me. (^: )
There was a problem hiding this comment.
Yeah, this crossed my mind, but I felt like this page is for advanced users who are familiar with crypto. On the flipside, we haven't done a good job of getting people to use Master Ticket (even if they bought a planet from a third-party)
| full | ||
| as={SubmitButton} | ||
| center | ||
| handleSubmit={handleSubmit}> | ||
| {isWarning => |
There was a problem hiding this comment.
Maybe this is as good a time as any to tear this out. See also #405. (But we might want further discussion on that.)
There was a problem hiding this comment.
Yeah while I was styling this, I felt like it was an unnecessary layer of abstraction, but what do I know lol
