generate keyfile as part of network key tx #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you explain the reasoning behind this fix? I'm having trouble seeing what problematic case this solves, and how exactly it solves that. |
|
If the new keyfile takes a while to generate, then the downloadkeyfilebutton will serve a stale keyfile while the new keyfile is generating. Hence we don't show the downloadkeyfile button until we've finished generating a new one |
Fang-
approved these changes
Mar 24, 2020
This was referenced Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We generate the keyfile as part of the network key transaction to
hopefully prevent downloading stale.
Hopefully mitigates #346 and #137 although I am unable to reproduce
it.