ActivateCode: hide ticket input if it's implied #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hides the ticket and changes the copy if there's an implied point from the URL, in order to minimise user cognitive load. We don't skip this page entirely because we have to make network and crypto calls and doing this upon pageload would ruin time to interactive. Fixes #443
Fang-
reviewed
Apr 7, 2020
|
what browser @Fang- ? Do you have a running ganache? Works fine on mine(tm) |
|
I'm on Firefox. Had modified |
|
odd, just tried to repro w/ firefox and ropsten and worked fine. owned should never be null, so maybe check node_modules? |
Fang-
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hides the ticket and changes the copy if there's an implied point
from the URL, in order to minimise user cognitive load. We don't
skip this page entirely because we have to make network and crypto
calls and doing this upon pageload would ruin time to interactive.
cc: @kennyrowe
Fixes #443
