Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cell axis in Nock 9 crashes Vere #660

Closed
Quodss opened this issue Jun 20, 2024 · 0 comments
Closed

Cell axis in Nock 9 crashes Vere #660

Quodss opened this issue Jun 20, 2024 · 0 comments

Comments

@Quodss
Copy link
Contributor

Quodss commented Jun 20, 2024

If you run this in Dojo:

.*(0 [9 [2 2] 0 1])

you will get either a segfault or an assertion failure, followed by Vere crashing. The intended behaviour is a deterministic error.
@Quodss Quodss mentioned this issue Jun 20, 2024
Merged
pkova added a commit that referenced this issue Jun 24, 2024
@pkova
fix nock 9 crashing pier if axis is cell (#661)
36900c5 
Solves #660 

Prevents Nock 9 from crashing the pier if the axis argument is a cell.
Without the check Vere may call `u3qc_cap` on a cell, leading to a
segfault or an assertion failure:

```
Assertion '_(u3a_is_atom(b))' failed in pkg/noun/retrieve.c:1011
```

To reproduce the bug, run in Dojo:

```
.*(0 [9 [2 2] 0 1])
```

Is there a way to add a unit test to guard against a downgrade?
@pkova pkova closed this as completed Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Quodss @pkova