Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated GMP assembly sources on x86_64 linux #733

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Conversation

ripperi
Copy link
Contributor

@ripperi ripperi commented Oct 10, 2024

No description provided.

@ripperi ripperi requested a review from a team as a code owner October 10, 2024 15:51
@ripperi ripperi changed the title Fix generated assembly sources on x86_64 linux Fix generated GMP assembly sources on x86_64 linux Oct 10, 2024
@pkova pkova merged commit 218e8a1 into develop Oct 10, 2024
2 checks passed
@pkova pkova deleted the ripa/gmp-gen-fix branch October 10, 2024 17:01
@joemfb
Copy link
Member

joemfb commented Oct 11, 2024

What was different about the command use to generate these sources? Can that be captured in a README?

@ripperi
Copy link
Contributor Author

ripperi commented Oct 11, 2024

What was different about the command use to generate these sources? Can that be captured in a README?

It seemed I had forgotten to provide at least the --host=x86_64-linux-musl configure option. We should definitely document the exact options we use for each target

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants