altsrc: Parse durations from strings #641
Conversation
|
👍 This seems reasonable to me, but do you mind adding a couple of tests for this behavior? cc/ @ChrisPRobinson since I think you still have the most context on |
|
@cbranch 👍, seems good other than tests. Reviewing my code I think what I should have done re #599 was just to add those types to the system. I also like what you have done for duration as well, accepting a string seems good there |
cbranch
force-pushed
the
altsrc-parse-durations
branch
2 times, most recently
from
d09ed35 to
c265724
Compare
|
Finally got back to this one! |
altsrc/map_input_source.go
Outdated
| } | ||
|
|
||
| return 0, nil | ||
| } | ||
|
|
||
| func castDuration(name string, value interface{}) (time.Duration, error) { | ||
| otherValue, isType := value.(time.Duration) | ||
| if !isType { |
There was a problem hiding this comment.
Nitpick, but can we do an early return like
if isType {
return otherValue, nil
}
...Just to remove some of the nesting.
cbranch
force-pushed
the
altsrc-parse-durations
branch
from
c265724 to
01b6b91
Compare
|
Just waiting for build to finish (the failure looked like it might have been a CI flake). |
|
Fixed the build failure in #703. Apologies for the delay! |
Fixes part of #599.
I don't have a good idea (or the requirement) for fixing the other datatypes in that issue; presumably it should show the same leniency with exact types when parsing from weakly-typed data sources.